Hey there, we're working with this library for @keep-network. @pdyraga submitted #2 earlier this week, and we're interested in continuing to upstream further changes (if any); however, one of them is that we don't need the marshaling/unmarshaling code for BSON and JSON (we may need protobuf). We're thinking of refactoring the marshaling so that it can live in its own package and consumers can import the marshaling they need. Is that a change you'd be interested in pulling back into this repo?
Hey there, we're working with this library for @keep-network. @pdyraga submitted #2 earlier this week, and we're interested in continuing to upstream further changes (if any); however, one of them is that we don't need the marshaling/unmarshaling code for BSON and JSON (we may need protobuf). We're thinking of refactoring the marshaling so that it can live in its own package and consumers can import the marshaling they need. Is that a change you'd be interested in pulling back into this repo?
Totally, as a stand alone crypto package, the marshalling/unmarshalling
should be a separate issue. Json might be ok to keep as it does not
require external dependancies but bson is a very odd dependency. I would
totally accept any pull request in that direction.
Hey there, we're working with this library for @keep-network https://github.com/keep-network. @pdyraga https://github.com/pdyraga
submitted #2https://github.com/didiercrunch/paillier/pull/2 earlier
this week, and we're interested in continuing to upstream further changes
(if any); however, one of them is that we don't need the
marshaling/unmarshaling code for BSON and JSON (we may need protobuf).
We're thinking of refactoring the marshaling so that it can live in its own
package and consumers can import the marshaling they need. Is that a change
you'd be interested in pulling back into this repo?
Totally, as a stand alone crypto package, the marshalling/unmarshalling
should be a separate issue. Json might be ok to keep as it does not
require external dependancies but bson is a very odd dependency. I would
totally accept any pull request in that direction.
Didier
On Thu, Jun 7, 2018, 10:18 AM Antonio Salazar Cardozo <
notifications@github.com> wrote:
> Hey there, we're working with this library for @keep-network
> <https://github.com/keep-network>. @pdyraga <https://github.com/pdyraga>
> submitted #2 <https://github.com/didiercrunch/paillier/pull/2> earlier
> this week, and we're interested in continuing to upstream further changes
> (if any); however, one of them is that we don't need the
> marshaling/unmarshaling code for BSON and JSON (we may need protobuf).
> We're thinking of refactoring the marshaling so that it can live in its own
> package and consumers can import the marshaling they need. Is that a change
> you'd be interested in pulling back into this repo?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/didiercrunch/paillier/issues/3>, or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AC4UlJvW80vMdRIgVQSvCzjSkdAoXVb6ks5t6TYjgaJpZM4UegCD>
> .
>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Hey there, we're working with this library for @keep-network. @pdyraga submitted #2 earlier this week, and we're interested in continuing to upstream further changes (if any); however, one of them is that we don't need the marshaling/unmarshaling code for BSON and JSON (we may need protobuf). We're thinking of refactoring the marshaling so that it can live in its own package and consumers can import the marshaling they need. Is that a change you'd be interested in pulling back into this repo?
Totally, as a stand alone crypto package, the marshalling/unmarshalling
should be a separate issue. Json might be ok to keep as it does not
require external dependancies but bson is a very odd dependency. I would
totally accept any pull request in that direction.
Didier
On Thu, Jun 7, 2018, 10:18 AM Antonio Salazar Cardozo <
notifications@github.com> wrote:
Good to hear! Hope to offer up a PR soon :)
#4 closed this!